-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for PHP 8.4.0 #84
base: 1.27.x
Are you sure you want to change the base?
Conversation
cce17b9
to
f5f8e0c
Compare
Waiting for: laminas/laminas-loader#13 |
@mkoprek PHP 8.4 support added in https://github.com/laminas/laminas-loader/releases/tag/2.11.0 |
bab3644
to
4d8b06f
Compare
I don't have idea why it output so many error at PHPUnit 8.4 lowest. It requires specific knowledge in CI configuration which I don't have. Maybe someone can help with it? |
To begin with run Many of the issues here are incompatibilities with PHPUnit and 8.4 |
Try adding .laminas-ci.json. |
670b5d2
to
b270c62
Compare
@alexmerlin I've added |
I don't think it will help in this case. Dependencies are right now in almost newest versions. |
I do think it will help in this case because deps are not almost newest when testing on lowest 🤷♂️ |
25fa360
to
bea5ee6
Compare
@gsteel You was right. I was sure CI is working in other way. There is last unit test to fix, maybe I will try to fix it at the weekend. |
@mkoprek Any progress with fixing the tests? |
@alexmerlin sorry, didn't have time for it yet. Maybe someone else can move it forward? |
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: Abdul Malik Ikhsan <[email protected]> Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: Maciej Koprek <[email protected]>
473db9d
to
a9627c6
Compare
@alexmerlin Maybe not the fastest, but it finally worked out. Waiting for some CR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
@Ocramius Hey, could you please take a look? |
Description