Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP 8.4.0 #84

Open
wants to merge 22 commits into
base: 1.27.x
Choose a base branch
from

Conversation

mkoprek
Copy link
Contributor

@mkoprek mkoprek commented Oct 12, 2024

Q A
Documentation no
Bugfix no
BC Break yes
New Feature no
RFC no
QA no

Description

@mkoprek mkoprek force-pushed the add_support_for_php_84 branch from cce17b9 to f5f8e0c Compare October 12, 2024 18:46
@mkoprek mkoprek changed the title Add support for PHP 8.4.0 [WIP] Add support for PHP 8.4.0 Oct 12, 2024
@mkoprek
Copy link
Contributor Author

mkoprek commented Oct 12, 2024

Waiting for: laminas/laminas-loader#13

@alexmerlin
Copy link
Member

@mkoprek
Copy link
Contributor Author

mkoprek commented Oct 22, 2024

I don't have idea why it output so many error at PHPUnit 8.4 lowest. It requires specific knowledge in CI configuration which I don't have. Maybe someone can help with it?

@gsteel
Copy link
Member

gsteel commented Oct 22, 2024

I don't have idea why it output so many error at PHpUnit 8.4 lowest. It requires specific knowledge in CI configuration which I don't have. Maybe someone can help with it?

To begin with run composer update; composer bump -D locally to bump dev dependencies to the latest supported releases and push again to run CI.

Many of the issues here are incompatibilities with PHPUnit and 8.4

@alexmerlin
Copy link
Member

Try adding .laminas-ci.json.
With this, platform dependencies will be ignored - this was done in other packages as well to fix the issue until PHP 8.4 is officially released.

@mkoprek mkoprek force-pushed the add_support_for_php_84 branch from 670b5d2 to b270c62 Compare October 22, 2024 17:50
@mkoprek
Copy link
Contributor Author

mkoprek commented Oct 22, 2024

@alexmerlin I've added ignore_php_platform_requirements to .laminas-ci.json. There are still same errors, any other idea?

@mkoprek
Copy link
Contributor Author

mkoprek commented Oct 22, 2024

To begin with run composer update; composer bump -D locally to bump dev dependencies to the latest supported releases and push again to run CI.

Many of the issues here are incompatibilities with PHPUnit and 8.4

I don't think it will help in this case. Dependencies are right now in almost newest versions.

@gsteel
Copy link
Member

gsteel commented Oct 22, 2024

I don't think it will help in this case. Dependencies are right now in almost newest versions.

I do think it will help in this case because deps are not almost newest when testing on lowest 🤷‍♂️

@mkoprek mkoprek force-pushed the add_support_for_php_84 branch from 25fa360 to bea5ee6 Compare October 23, 2024 10:47
@mkoprek
Copy link
Contributor Author

mkoprek commented Oct 23, 2024

@gsteel You was right. I was sure CI is working in other way.

There is last unit test to fix, maybe I will try to fix it at the weekend.

@alexmerlin
Copy link
Member

@mkoprek Any progress with fixing the tests?

@mkoprek
Copy link
Contributor Author

mkoprek commented Nov 26, 2024

@alexmerlin sorry, didn't have time for it yet.

Maybe someone else can move it forward?

renovate bot and others added 12 commits November 28, 2024 21:56
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: Maciej Koprek <[email protected]>
Maciej Koprek and others added 9 commits November 28, 2024 21:56
Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: Abdul Malik Ikhsan <[email protected]>
Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Maciej Koprek <[email protected]>
Signed-off-by: Maciej Koprek <[email protected]>
@mkoprek mkoprek force-pushed the add_support_for_php_84 branch from 473db9d to a9627c6 Compare November 28, 2024 20:58
@mkoprek mkoprek changed the title [WIP] Add support for PHP 8.4.0 Add support for PHP 8.4.0 Nov 28, 2024
@mkoprek mkoprek changed the base branch from 1.26.x to 1.27.x November 28, 2024 21:03
@mkoprek
Copy link
Contributor Author

mkoprek commented Nov 28, 2024

@alexmerlin Maybe not the fastest, but it finally worked out.

Waiting for some CR

Copy link
Member

@alexmerlin alexmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@mkoprek
Copy link
Contributor Author

mkoprek commented Dec 5, 2024

@Ocramius Hey, could you please take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

5 participants